linux-kernel - Re: [PATCH 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201105311328.18012.arnd@arndb.de>
Date:	Tue, 31 May 2011 13:28:17 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Shawn Guo <shawn.guo@...escale.com>
Cc:	Olof Johansson <olof@...om.net>, Shawn Guo <shawn.guo@...aro.org>,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca,
	kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
	patches@...aro.org
Subject: Re: [PATCH 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc

On Tuesday 31 May 2011, Shawn Guo wrote:
> > Just open-code the mxc_add_mxc_gpio() by moving the individual calls to
> > mxc_add_gpio() into the respective callers. Having a global
> > mxc_add_mxc_gpio() function that does something different for each
> > caller seems entirely pointless to me.
> > 
> Right now, mxc_add_mxc_gpio() is a postcore_initcall.  Moving
> individual mxc_add_gpio() call into irq_init function does not work.
> And I need to find a proper caller for each SoC to call mxc_add_gpio
> to register gpio devices.
 
Why not init_machine? That is an arch_initcall(), so it's probably close
enough.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/