linux-kernel - Re: blkdev_get() change causes OOPS...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110531.131352.297345785.davem@davemloft.net>
Date:	Tue, 31 May 2011 13:13:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: blkdev_get() change causes OOPS...

From: Tejun Heo <tj@...nel.org>
Date: Wed, 1 Jun 2011 00:37:44 +0900

> On Mon, May 30, 2011 at 10:35:07PM -0700, David Miller wrote:
>> 
>> I don't think whole->bd_disk is guaranteed to be non-NULL where you're
>> dereferencing it in blkdev_get() after commit
>> d4dc210f69bcb0b4bef5a83b1c323817be89bad1 ("block: don't block events
>> on excl write for non-optical devices")
> 
> Ah... right, it's there if open succeeded.  I should have put the test
> after !res test.  Does the following patch fix the problem?

Works here:

Acked-by: David S. Miller <davem@...emloft.net>

Make sure this fix propagates into the stable submission.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/