linux-kernel - RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1106070941580.1972-100000@iolanthe.rowland.org>
Date:	Tue, 7 Jun 2011 09:45:28 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Tanya Brokhman <tlinder@...eaurora.org>
cc:	greg@...ah.com, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <balbi@...com>,
	<ablay@...eaurora.org>, 'open list' <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection
 according to module parameter

On Tue, 7 Jun 2011, Tanya Brokhman wrote:

> > You might want to print out some kind of error message if the user
> > specifies is_super_speed = True and is_high_speed = False.
> > 
> 
> I thought about that as well. Even added it but removed at the last minute
> :) I encountered quite a few places in the code where some error message to
> the user is really needed but is missing

What other places?  There is very little the user has to do with 
dummy-hcd -- really nothing more than setting the module parameters.

>  so my impression was that it's best
> to keep the printks to a minimum. Isn't that the general approach? IMO, in
> this particular case informing the user isn't a "must". If you feel strongly
> about it I can add the message.

IMO the driver should print an error message and fail to load if there 
are contradictory module parameters.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/