linux-kernel - RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <016d01cc2541$0bfa5980$23ef0c80$@org>
Date:	Tue, 7 Jun 2011 21:30:46 +0300
From:	"Tanya Brokhman" <tlinder@...eaurora.org>
To:	"'Alan Stern'" <stern@...land.harvard.edu>
Cc:	<greg@...ah.com>, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <balbi@...com>,
	<ablay@...eaurora.org>,
	"'open list'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter

> > I thought about that as well. Even added it but removed at the last
> minute
> > :) I encountered quite a few places in the code where some error
> message to
> > the user is really needed but is missing
> 
> What other places?  There is very little the user has to do with
> dummy-hcd -- really nothing more than setting the module parameters.

I'm not talking about dummy_hcd. It was a general comment about the gadget
code. I can't give you an example from the top of my head...

> >  so my impression was that it's best
> > to keep the printks to a minimum. Isn't that the general approach?
> IMO, in
> > this particular case informing the user isn't a "must". If you feel
> strongly
> > about it I can add the message.
> 
> IMO the driver should print an error message and fail to load if there
> are contradictory module parameters.
> 

Well, I can add the error message but I think that as far as dummy_hcd is
concerned failing it's loading is a bit harsh, isn't it? I mean, this is a
type of user error that can be fixed so why not fix it and just notify the
user of what was done?


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/