lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BANLkTi=8+Y5je60goSnr3Zucjmh+RKvQwA@mail.gmail.com>
Date:	Tue, 7 Jun 2011 11:30:36 +0800
From:	Eric Miao <eric.miao@...aro.org>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Nick Piggin <npiggin@...il.com>
Subject: Re: [PATCH] brd: make brd_make_request() return error code

On Fri, Jun 3, 2011 at 1:02 PM, Eric Miao <eric.miao@...aro.org> wrote:
> brd_make_request() always returns 0, which doesn't make much sense.
>
> Signed-off-by: Eric Miao <eric.miao@...aro.org>
> ---
>  drivers/block/brd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index dba1c32..a9587ee 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -360,7 +360,7 @@ static int brd_make_request(struct request_queue *q, struct bio *bio)
>  out:
>        bio_endio(bio, err);
>
> -       return 0;
> +       return err;
>  }
>
>  #ifdef CONFIG_BLK_DEV_XIP
> --
> 1.7.4.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ