linux-kernel - Re: [Cocci] [RFC] Convert "resource->end - resource->start + 1" to resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1106070741510.18329@ask.diku.dk>
Date:	Tue, 7 Jun 2011 07:42:56 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Joe Perches <joe@...ches.com>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	cocci <cocci@...u.dk>, vinod.koul@...el.com,
	dan.j.williams@...el.com,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Cocci] [RFC] Convert "resource->end - resource->start + 1" to
 resource_size(resource) via coccinelle

On Mon, 6 Jun 2011, Joe Perches wrote:

> On Tue, 2011-06-07 at 07:07 +0200, Julia Lawall wrote:
> > On Mon, 6 Jun 2011, Joe Perches wrote:
> > > Perhaps do a treewide update via:
> > > $ cat resource.cocci
> > > @@
> > > struct resource *ptr;
> > > @@
> > > - ptr->end - ptr->start + 1
> > > + resource_size(ptr)
> > > $ spatch -sp_file resource.cocci linux-2.6/
> > There might be some cases that have the +1 in a different place, or that 
> > have some parentheses.
> > I suspect that a lot of these non-uses of resource_size still exist.
> 
> True enough.
> 
> Cocci already handles the parens case
> "(foo->end-foo->start)+1"

If you put parentheses, it will consider removing them.  But I don't think 
it would go the other way around.

julia

> There are some uses of end+1-start and
> 1+end-start that weren't converted by
> the patch I sent.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/