linux-kernel - Re: [Cocci] [RFC] Convert "resource->end - resource->start + 1" to resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1307432547.1651.11.camel@Joe-Laptop>
Date:	Tue, 07 Jun 2011 00:42:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	cocci <cocci@...u.dk>, vinod.koul@...el.com,
	dan.j.williams@...el.com,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Cocci] [RFC] Convert "resource->end - resource->start + 1" to
 resource_size(resource) via coccinelle

On Tue, 2011-06-07 at 07:42 +0200, Julia Lawall wrote:
> On Mon, 6 Jun 2011, Joe Perches wrote:
> > Cocci already handles the parens case
> > "(foo->end-foo->start)+1"
> If you put parentheses, it will consider removing them.  But I don't think 
> it would go the other way around.

It does.

$ spatch -very_quiet -sp_file resource.cocci t2.c
--- t2.c	2011-06-07 00:37:48.000000000 -0700
+++ /tmp/cocci-output-3529-9bb101-t2.c	2011-06-07 00:38:31.000000000
-0700
@@ -12,7 +12,7 @@ void test_resource(void)
 {
 	int i;
 	for (i = 0; i < ARRAY_SIZE(array); i++) {
-		if ((p[i].end - p[i].start) + 1 > 0x12345)
+		if (resource_size(p) > 0x12345)
 			printk(KERN_CRIT "Some failure\n");
 	}
 }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/