linux-kernel - Re: [PATCH 1/3] x86: Readd asmregparm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1106080719000.9853@router.home>
Date:	Wed, 8 Jun 2011 07:28:52 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Pekka Enberg <penberg@...nel.org>
cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/3] x86: Readd asmregparm

On Wed, 8 Jun 2011, Pekka Enberg wrote:

> Hi Andi,
>
> On Wed, Jun 8, 2011 at 11:37 AM, Andi Kleen <andi@...stfloor.org> wrote:
> >> That's a totally useless changelog (you are deliberately hiding
> >> information again) so the series is obviously not acceptable.
> >> Please fix and resend.
> >
> > I reread it and it seems complete to me. Please be more specific.
> >
> > If you refer to the followon patchkit - it's not ready for posting
> > yet. However I believe these changes are reasonable cleanups that are useful
> > on their own. That's why I posted them now.
>
> So from my point of view, none of the changelogs explain why the
> changes needed. Now, I'm not an expert on the x86 code so maybe I'm
> missing something obvious but to me the only rationale seems to be
> that you need it some unspecified follow-up patchkit. HTH.

Ok but the changelog is explaining the patch as far as I can tell. Its
just that there is not enough of a justification for inclusion without the
follow on patches and clarity on the ultimate purpose of the whole
endeavor. In general some more specificity and less emotions may be
helpful.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/