linux-kernel - Re: [PATCH 1/3] x86: Readd asmregparm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110608160128.GN27166@one.firstfloor.org>
Date:	Wed, 8 Jun 2011 18:01:28 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/3] x86: Readd asmregparm

> So from my point of view, none of the changelogs explain why the
> changes needed. Now, I'm not an expert on the x86 code so maybe I'm
> that you need it some unspecified follow-up patchkit. HTH.

Proper asmlinkages are imho a cleanliness feature that stands
on its own. They have been used in the past for all kinds of things,
but unfortunately have bitrotted recently on x86.

If nothing else they are useful documentation. For example
if you do grep for *.[ch] only and you hit an asmlinkage it's a good
hint to look into the .S too. In general you need to be much more
careful about any changes to those, because assembler is more fragile.

I have been encouraged by other people to post those early, so I did.
and at least in my traditional Linux development world view posting 
patches early is the right thing to do.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/