linux-kernel - Re: [PATCH] x86: CONFIG_EFI should select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110609144736.GA27953@srcf.ucam.org>
Date:	Thu, 9 Jun 2011 15:47:36 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org, pjones@...hat.com
Subject: Re: [PATCH] x86: CONFIG_EFI should select CONFIG_RELOCATABLE

On Thu, Jun 09, 2011 at 07:37:31AM -0700, H. Peter Anvin wrote:
> On 06/09/2011 07:32 AM, Matthew Garrett wrote:
> >  config EFI
> >  	bool "EFI runtime service support"
> >  	depends on ACPI
> > +	select RELOCATABLE
> >  	---help---
> >  	  This enables the kernel to use EFI runtime services that are
> >  	  available (such as the EFI variable services).
> 
> Can we make this a depends on instead of select?

CONFIG_RELOCATABLE has no dependencies so select should be safe, and 
depends means CONFIG_EFI vanishes until you turn on something that seems 
entirely unrelated. I've no problem with it being depends, but this 
seems friendlier.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/