linux-kernel - Re: + sysctl-add-proc_dointvec_unsigned-handler-update.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikAvnam2WNTBMj_J5yBHrxJxSjLuw@mail.gmail.com>
Date:	Thu, 9 Jun 2011 20:19:50 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	akpm@...ux-foundation.org
Cc:	linux-kernel@...r.kernel.org, hidave.darkstar@...il.com,
	ebiederm@...ssion.com
Subject: Re: + sysctl-add-proc_dointvec_unsigned-handler-update.patch added to
 -mm tree

On Wed, Jun 8, 2011 at 11:45 PM,  <akpm@...ux-foundation.org> wrote:
> --- a/kernel/sysctl.c~sysctl-add-proc_dointvec_unsigned-handler-update
> +++ a/kernel/sysctl.c
> @@ -2515,6 +2515,7 @@ int proc_dointvec_unsigned(struct ctl_ta
>  {
>        struct do_proc_dointvec_minmax_conv_param param = {
>                .min = &zero,
> +               .max = (int *) table->extra2,
>        };
>        return do_proc_dointvec(table, write, buffer, lenp, ppos,
>                                do_proc_dointvec_minmax_conv, &param);

This is still buggybecause "zero" is only 1 variable and max can be an array.
Sysctl boundary comparisons are done element-by-element.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/