linux-kernel - Re: [PATCH] regulator: Add rdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1307644635.13329.36.camel@Joe-Laptop>
Date:	Thu, 09 Jun 2011 11:37:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: Add rdev_crit() macro

On Thu, 2011-06-09 at 16:06 +0100, Mark Brown wrote:
> No actual users but provide the macro so there's less surprise when it's
> not there.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/regulator/core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 47bf85d..f5e4665 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -34,6 +34,8 @@
>  
>  #include "dummy.h"
>  
> +#define rdev_crit(rdev, fmt, ...)					\
> +	pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
>  #define rdev_err(rdev, fmt, ...)					\
>  	pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
>  #define rdev_warn(rdev, fmt, ...)					\

If that's really necessary, shouldn't rdev_emerg, rdev_alert
and rdev_notice be added as well?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/