linux-kernel - Re: [PATCH] regulator: Add rdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110609190925.GD2821@opensource.wolfsonmicro.com>
Date:	Thu, 9 Jun 2011 20:09:26 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: Add rdev_crit() macro

On Thu, Jun 09, 2011 at 11:37:15AM -0700, Joe Perches wrote:

> > +#define rdev_crit(rdev, fmt, ...)					\
> > +	pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)

> If that's really necessary, shouldn't rdev_emerg, rdev_alert
> and rdev_notice be added as well?

Yes, but I don't habitually use those when adding random trace during
debug so don't care myself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/