linux-kernel - Re: [PATCH 1/2] efi: Fix argument types for SetVariable()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110609190922.GA1805@srcf.ucam.org>
Date:	Thu, 9 Jun 2011 20:09:23 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Tony Luck <tony.luck@...el.com>
Cc:	x86@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] efi: Fix argument types for SetVariable()

On Thu, Jun 09, 2011 at 12:02:53PM -0700, Tony Luck wrote:
> On Mon, Jun 6, 2011 at 12:36 PM, Matthew Garrett <mjg@...hat.com> wrote:
> > diff --git a/include/linux/efi.h b/include/linux/efi.h
> > index e376270..0758753 100644
> > --- a/include/linux/efi.h
> > +++ b/include/linux/efi.h
> > @@ -168,7 +168,7 @@ typedef efi_status_t efi_get_variable_t (efi_char16_t *name, efi_guid_t *vendor,
> >  typedef efi_status_t efi_get_next_variable_t (unsigned long *name_size, efi_char16_t *name,
> >                                              efi_guid_t *vendor);
> >  typedef efi_status_t efi_set_variable_t (efi_char16_t *name, efi_guid_t *vendor,
> > -                                        unsigned long attr, unsigned long data_size,
> > +                                        u32 attr, unsigned long data_size,
> >                                         void *data);
> >  typedef efi_status_t efi_get_next_high_mono_count_t (u32 *count);
> >  typedef void efi_reset_system_t (int reset_type, efi_status_t status,
> 
> x86 isn't the only user of <linux/efi.h>
> 
> Building next-20110609 I see:
> 
> arch/ia64/kernel/efi.c:578: warning: assignment from incompatible pointer type
> arch/ia64/kernel/efi.c:701: warning: assignment from incompatible pointer type

Oops. I'll follow up.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/