linux-kernel - Re: [PATCH] m68k: Patch for broken lsl64() "old code" with incorrect shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikk2v8m1wNYoTW6anRhJgy8AS9DfA@mail.gmail.com>
Date:	Sat, 11 Jun 2011 08:34:18 -0400
From:	Jonathan Elchison <JElchison@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-m68k@...ts.linux-m68k.org, Jiri Kosina <trivial@...nel.org>,
	linux-kernel@...r.kernel.org, David Huggins-Daines <dhd@...ian.org>
Subject: Re: [PATCH] m68k: Patch for broken lsl64() "old code" with incorrect shift

On Sat, Jun 11, 2011 at 8:01 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> I think it's better to just remove all #ifdefed out parts in the code.

I'm good either way, as long as the broken "old code" is no longer present.

> The patch is reversed?

My apologies, you're correct.  In case anyone is interested in the
correct patch:

Signed-off-by: Jonathan Elchison <jelchison@...il.com>

-----------------------------------------------------------------
diff -up linux-2.6_orig/arch/m68k/math-emu/multi_arith.h
linux-2.6/arch/m68k/math-emu/multi_arith.h
--- linux-2.6_orig/arch/m68k/math-emu/multi_arith.h	2011-06-10
22:47:43.407285452 -0400
+++ linux-2.6/arch/m68k/math-emu/multi_arith.h	2011-06-10
22:50:32.538711320 -0400
@@ -236,7 +236,7 @@ static inline void lsl64(int count, unsi
 {
 	if (count < 32) {
 		HI_WORD(*dest) = (HI_WORD(*dest) << count)
-		    | (LO_WORD(*dest) >> count);
+		    | (LO_WORD(*dest) >> (32 - count));
 		LO_WORD(*dest) <<= count;
 		return;
 	}
-----------------------------------------------------------------

Please personally CC me on responses to this post.

v/r,

--
Jonathan Elchison
jelchison@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/