linux-kernel - Re: [GIT PULL] sound fixes for 3.0-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2011 21:40:37 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] sound fixes for 3.0-rc3

On Sun, Jun 12, 2011 at 06:18:52PM +0200, Takashi Iwai wrote:
> > Please give alsa-info.sh output with the working kernel, i.e. 2.6.39
> > for comparison.

attached.

> > Also, try model=auto option for snd-hda-intel.  I guess this would
> > work better nowadays.
> 
> Also, try the patch below.  This should fix your device (without
> model=auto).
> 
> 
> Takashi
> 
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 20f01f8..9b97af9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -13317,9 +13317,8 @@ static void alc268_acer_lc_setup(struct hda_codec *codec)
>  	struct alc_spec *spec = codec->spec;
>  	spec->autocfg.hp_pins[0] = 0x15;
>  	spec->autocfg.speaker_pins[0] = 0x14;
> -	spec->automute_mixer_nid[0] = 0x0f;
>  	spec->automute = 1;
> -	spec->automute_mode = ALC_AUTOMUTE_MIXER;
> +	spec->automute_mode = ALC_AUTOMUTE_AMP;
>  	spec->ext_mic.pin = 0x18;
>  	spec->ext_mic.mux_idx = 0;
>  	spec->int_mic.pin = 0x12;

Yep, it does.

Tested-by: Borislav Petkov <bp@...en8.de>

Btw, I keep noticing those when building on 32bit:

sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5045’:
sound/pci/hda/patch_conexant.c:1232:3: warning: statement with no effect
sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5051’:
sound/pci/hda/patch_conexant.c:2067:3: warning: statement with no effect
sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5066’:
sound/pci/hda/patch_conexant.c:3261:3: warning: statement with no effect
sound/pci/hda/patch_conexant.c: In function ‘patch_conexant_auto’:
sound/pci/hda/patch_conexant.c:4370:3: warning: statement with no effect

Thanks.

-- 
Regards/Gruss,
    Boris.

View attachment "alsa-info.txt.EgpeIEqXye-2.6.39" of type "text/plain" (14725 bytes)