linux-kernel - Re: [PATCH]drivers:base:power:trace.c Add "UTC" Coordinated Universal Time to the printk.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201106122227.32992.rjw@sisk.pl>
Date:	Sun, 12 Jun 2011 22:27:32 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH]drivers:base:power:trace.c Add "UTC" Coordinated Universal Time to the printk.

On Sunday, June 12, 2011, Justin P. Mattock wrote:
> On 06/12/2011 11:35 AM, Rafael J. Wysocki wrote:
> > On Sunday, June 12, 2011, Justin P. Mattock wrote:
> >> On 06/12/2011 05:12 AM, Rafael J. Wysocki wrote:
> >>> Hi,
> >>>
> >>> On Thursday, June 09, 2011, Justin P. Mattock wrote:
> >>>> From: "Justin P. Mattock"<justinmattock@...il.com>
> >>>>
> >>>> sounds stupid, but taking a glance at the time, and seeing the wrong time, or what seemed
> >>>> wrong in dmesg, caused me to go into total check the time clock panic mode.. So the patch below adds:
> >>>> "UTC" Coordinated Universal Time abreviation to the printk so people like me dont flip out over the time!
> >>>>
> >>>> before:
> >>>> [    0.114915] Time:  1:47:03  Date: 06/09/11
> >>>>
> >>>> after:
> >>>> [    0.114728] Time:  5:46:02 UTC Date: 06/09/11
> >>>>
> >>>> Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
> >>>
> >>> I suspect the goal is to mark messages printed by the PM trace code so that
> >>> they can be easily distinguished from messages from other sources to avoid
> >>> confusion.  Why do you think it's a good idea to use the "UTC" string for
> >>> this purpose?  The time printed in those messages need not be UTC.
> >>>
> >>> It would be better to simply print "RTC time: ..., date: ..." IMO.
> >>>
> >>> Thanks,
> >>> Rafael
> >>>
> >>
> >> well.. if thats better, then thats better.. over here(people that dont
> >> know what RTC time is) would not get so confused with a simple UTC or
> >> PDT or whatever the time zone is but if RTC is bettr, then its better.
> >
> > My point is we don't know this time is always UTC, so we rather shouldn't
> > label it as UTC unconditionally, should we?
> >
> > Rafael
> >
> 
> sounds good to me!!

I'm not sure what you mean?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/