linux-kernel - Re: [PATCH] hid-multitouch: fix broken eGalax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2011 23:15:00 +0200
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid-multitouch: fix broken eGalax

Hi Benjamin,

> >> With this patch, the detection is made only when the field ContactID
> >> has been detected inside the collection.
> >
> > The patch introduces an order dependence by relying on ContactID
> > occuring early on, which seems unnecessary. How about checking for the
> > presence of ContactID instead, and simply modify the logic which uses
> > last_field_index and last_slot_field?
> 
> That's exactly what it does. A touch report has to contain the
> contactID field. And each touch is at least in one collection (some
> devices send one touch per collection, others only one collection for
> the whole report).
> The idea is when hardware makers introduce several input mode for
> their device, they has to put them in different collections.

Ah, right you are, the ensured presence of ContactID is enough to
prove that the patch code is equivalent.

> The logic behind the last_field_index and last_slot_field are only for
> multitouch. So it does not matter if the contactID comes first or last
> in the collection, it will set the right index/field.

Thanks for the clarification.

    Reviewed-by: Henrik Rydberg <rydberg@...omail.se>

Cheers,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/