linux-kernel - Re: [PATCH] hid-multitouch: fix broken eGalax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1106122359300.22872@pobox.suse.cz>
Date:	Mon, 13 Jun 2011 00:01:35 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires <benjamin.tissoires@...c.fr>,
	Henrik Rydberg <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid-multitouch: fix broken eGalax

On Sun, 12 Jun 2011, Benjamin Tissoires wrote:

> Since the inclusion of eGalax devices in 2.6.39, I've got some
> bug reports for 480d and other devices.
> The problem lies in the reports descriptors: eGalax supports both
> pen and fingers, and so the reports descriptors contained both.
> But hid-multitouch relies on them to detect the last item in each
> field to send the multitouch events. In 480d, the last item is not
> Y as it should but Pressure. That means that the fields are not
> aligned and X,Y are at 0,0 (the other touch coordinates of the report).
> 
> With this patch, the detection is made only when the field ContactID
> has been detected inside the collection.
> 
> There is still a problem with the detections of the range as stylus
> and fingers may not have the same min/max, but it's a start.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr>
> ---
> 
> Hi guys,
> 
> I'd love to see this patch into stable too. The point is that it does
> not applies out of the box. Should I send it again to stable@...nel.org
> once the reviews has been made?

The best thing is to wait for the patch to appear in Linus' tree (which is 
a prerequisity for -stable inclusion anyway), and then send a backported 
version, with upstream reference commit, to stable@...nel.org.

On Sun, 12 Jun 2011, Henrik Rydberg wrote:

> Thanks for the clarification.
> 
>     Reviewed-by: Henrik Rydberg <rydberg@...omail.se>

Thanks, I have now applied it.

I am waiting with pushing my upstream-fixes branch to Linus before the 
magicmouse issue has been sorted out (waiting for tester Ack). If this 
doesn't happen in a day or two, I will be pushing it anyway.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/