linux-kernel - Re: [PATCH 1/1] kernel/sched.c: Fix array initialization typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110612220116.GB12311@mail.gmail.com>
Date:	Sun, 12 Jun 2011 16:01:16 -0600
From:	Jean Sacren <sakiwit@...il.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] kernel/sched.c: Fix array initialization typo

From: Alexey Dobriyan <adobriyan@...il.com>
Date: Mon, 13 Jun 2011 00:35:49 +0300
>
> On Sun, Jun 12, 2011 at 03:31:07PM -0600, Jean Sacren wrote:
> > The fix makes certain so that the size of the initialized arrays doesn't
> > go beyond the boundary set by the array size of 40.
> 
> Why would it possibly do that?

With that ',' comma, doesn't it imply there might be the 41st element in
the array? Despite the fact that that element is bogus.

Further, if the comma is there, what's the benefit? I know you're cool,
but is it cool in code that way as well?
> 
> And it's not a typo.

What is it then?
> 
> > @@ -1383,7 +1383,7 @@ static const int prio_to_weight[40] = {
> >   /*   0 */      1024,       820,       655,       526,       423,
> >   /*   5 */       335,       272,       215,       172,       137,
> >   /*  10 */       110,        87,        70,        56,        45,
> > - /*  15 */        36,        29,        23,        18,        15,
> > + /*  15 */        36,        29,        23,        18,        15
> >  };
> >  
> >  /*
> > @@ -1401,7 +1401,7 @@ static const u32 prio_to_wmult[40] = {
> >   /*   0 */   4194304,   5237765,   6557202,   8165337,  10153587,
> >   /*   5 */  12820798,  15790321,  19976592,  24970740,  31350126,
> >   /*  10 */  39045157,  49367440,  61356676,  76695844,  95443717,
> > - /*  15 */ 119304647, 148102320, 186737708, 238609294, 286331153,
> > + /*  15 */ 119304647, 148102320, 186737708, 238609294, 286331153
> >  };

-- 
Jean Sacren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/