linux-kernel - Re: [PATCH] hid-multitouch: fix broken eGalax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2011 17:12:45 -0500
From:	Chris Bagwell <chris@...bagwell.com>
To:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid-multitouch: fix broken eGalax

On Sun, Jun 12, 2011 at 1:22 AM, Benjamin Tissoires
<benjamin.tissoires@...c.fr> wrote:
> Since the inclusion of eGalax devices in 2.6.39, I've got some
> bug reports for 480d and other devices.
> The problem lies in the reports descriptors: eGalax supports both
> pen and fingers, and so the reports descriptors contained both.
> But hid-multitouch relies on them to detect the last item in each
> field to send the multitouch events. In 480d, the last item is not
> Y as it should but Pressure. That means that the fields are not
> aligned and X,Y are at 0,0 (the other touch coordinates of the report).
>
> With this patch, the detection is made only when the field ContactID
> has been detected inside the collection.
>
> There is still a problem with the detections of the range as stylus
> and fingers may not have the same min/max, but it's a start.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr>

This patch was good timing for me.  I was giving the latest
hid-multitouch a try on my MosArt touchscreen (0486:0186).  hid-mosart
was basically working but once merged into hid-multitouch,
hid-multitouch was not.

The symptom was once you touched screen, it acted like user never
released touch.

I tracked it down today to last_field_index being reset from 14 to 2
because of an unused extra input in descriptor that looked like a
mouse (X/Y and 2 buttons).  This to small index caused a delay of
sending valid data by 1 packet and since no packets sent after touch
release, you'd not get the release at appropriate time.

In my case, only the input with ContactID's are useful (there are 2
ContactID's spread between 2 collections) so this patch should prevent
last_field_index from being reset by the unused X/Y's.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/