linux-kernel - Re: [PATCH] sysctl: remove impossible condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1pqmj37um.fsf@fess.ebiederm.org>
Date:	Sat, 11 Jun 2011 23:02:41 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Nick Piggin <npiggin@...nel.dk>,
	Christoph Hellwig <hch@....de>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] sysctl: remove impossible condition check

Jesper Juhl <jj@...osbits.net> writes:

> On Fri, 10 Jun 2011, Lucas De Marchi wrote:
>
>> Remove checks for conditions that will never happen. If procname is NULL
>> the loop would already had bailed out, so there's no need to check it
>> again.
>> 
>> At the same time this also compacts the function find_in_table() by
>> refactoring it to be easier to read.
>> 
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
>
> Looks good to me.
>
> Reviewed-by: Jesper Juhl <jj@...osbits.net>

Applied thanks all.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/