linux-kernel - Re: [PATCH] sysctl: remove impossible condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1106100955280.19998@swampdragon.chaosbits.net>
Date:	Fri, 10 Jun 2011 09:56:18 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jesper Juhl <jj@...osbits.net>, linux-kernel@...r.kernel.org,
	Nick Piggin <npiggin@...nel.dk>,
	Christoph Hellwig <hch@....de>,
	Al Viro <viro@...iv.linux.org.uk>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
Subject: Re: [PATCH] sysctl: remove impossible condition check

On Fri, 10 Jun 2011, Lucas De Marchi wrote:

> Remove checks for conditions that will never happen. If procname is NULL
> the loop would already had bailed out, so there's no need to check it
> again.
> 
> At the same time this also compacts the function find_in_table() by
> refactoring it to be easier to read.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@...fusion.mobi>

Looks good to me.

Reviewed-by: Jesper Juhl <jj@...osbits.net>

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/