linux-kernel - Re: [PATCH] usb:gadget: use min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110613115723.GN3633@legolas.emea.dhcp.ti.com>
Date:	Mon, 13 Jun 2011 14:57:26 +0300
From:	Felipe Balbi <balbi@...com>
To:	Tanya Brokhman <tlinder@...eaurora.org>
Cc:	balbi@...com, greg@...ah.com, linux-usb@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, ablay@...eaurora.org,
	'open list' <linux-kernel@...r.kernel.org>,
	"'open list:FREESCALE USB PER...'" <linuxppc-dev@...ts.ozlabs.org>,
	"'open list:OMAP USB SUPPORT'" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi,

On Mon, Jun 13, 2011 at 02:52:34PM +0300, Tanya Brokhman wrote:
> > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote:
> > > Signed-off-by: Tatyana Brokhman <tlinder@...eaurora.org>
> > 
> > I need a sensible commit log for this. Why do we need to change all
> > min() to min_t() ?
> > 
> 
> Actually, Alan asked me to make this change in one place in dummy_hcd. I
> wasn't aware of the min_t macro before that. So when I searched the code for
> other places I found quite a few and just thought that it would be "nicer"
> to use min_t() instead of min() with casting. 
> So we don't "need" to make this change. Everything works as is. This patch
> only makes the code look nicer, nothing more.
> I can elaborate the above in the commit log if you want.

Yes, that's what I need. The question was supposed to be answered by the
commit log ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)