linux-kernel - Re: [PATCH] [RESEND] devres: Fix possible use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110614071540.GE8141@htj.dyndns.org>
Date:	Tue, 14 Jun 2011 09:15:40 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Maxin B John <maxin.john@...il.com>
Cc:	akpm@...ux-foundation.org, segooon@...il.com, jkosina@...e.cz,
	tglx@...utronix.de, eike-kernel@...tec.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] devres: Fix possible use after free

Hello,

On Tue, Jun 14, 2011 at 10:07:32AM +0300, Maxin B John wrote:
> A freed pointer is passed as an argument to the function "devres_destroy()" in
> "kernel/irq/devres.c" and "lib/devres.c". This patch fixes the possible use 
> after free.
> 
> It's notabug at this time, but the code is dangerous.

The code is not dangerous.  The pointer value is used strictly as key
and the code path is always properly serialized.  The change is to
appease access-after-free detection logic, similar to the way we
change the code to better accomodate sparse or other code analysys
tools.  Can you please update the patch description to reflect that?

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/