linux-kernel - Re: [PATCH] [RESEND] devres: Fix possible use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2011 15:09:34 +0100
From:	Maxin B John <maxin.john@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	akpm@...ux-foundation.org, segooon@...il.com, jkosina@...e.cz,
	tglx@...utronix.de, eike-kernel@...tec.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] devres: Fix possible use after free

Hi,

On Tue, Jun 14, 2011 at 8:15 AM, Tejun Heo <tj@...nel.org> wrote:
> On Tue, Jun 14, 2011 at 10:07:32AM +0300, Maxin B John wrote:
>> A freed pointer is passed as an argument to the function "devres_destroy()" in
>> "kernel/irq/devres.c" and "lib/devres.c". This patch fixes the possible use
>> after free.
>>
>> It's notabug at this time, but the code is dangerous.
>
> The code is not dangerous.  The pointer value is used strictly as key
> and the code path is always properly serialized.  The change is to
> appease access-after-free detection logic, similar to the way we
> change the code to better accomodate sparse or other code analysys
> tools.  Can you please update the patch description to reflect that?

You are right. I shouldn't have mentioned it as dangerous. I was trying to
make this patch description similar to the description present in the
previous patch:
http://www.spinics.net/lists/mm-commits/msg84313.html

This patch silences the Coverity Prevent's complains about this as
use-after-free bug. Please let me know if the updated patch description is OK.

"
A freed pointer is passed as an argument to the function "devres_destroy()" in
"kernel/irq/devres.c" and "lib/devres.c". This patch fixes the possible use
after free.
The change silences the static analysis tool (Coverity Prevent) complains
about this as use-after-free bug.
"

Best Regards,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/