linux-kernel - Re: [PATCH] [SCSI] LIBSAS: fix libsas link error issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308065367.2401.24.camel@mulgrave>
Date:	Tue, 14 Jun 2011 10:29:27 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	yxlraid@...il.com
Cc:	jack_wang@...sh.com, lucas.demarchi@...fusion.mobi,
	maciej.trela@...el.com, dan.j.williams@...el.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	yuxiangl@...vell.com, jfeng@...vell.com
Subject: Re: [PATCH] [SCSI] LIBSAS: fix libsas link error issue

On Tue, 2011-06-14 at 23:17 +0800, yxlraid@...il.com wrote:
> From: Xiangliang Yu <yuxiangl@...vell.com>
> 
> -- The value of child link rate should is minimum of link rate, or
>    command will fail if child link rate is bigger than parent link rate.
> 
> Signed-off-by: Xiangliang Yu <yuxiangl@...vell.com>
> ---
>  drivers/scsi/libsas/sas_expander.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index 874e29d..6ccca09 100644
> --- a/drivers/scsi/libsas/sas_expander.c
> +++ b/drivers/scsi/libsas/sas_expander.c
> @@ -638,7 +638,7 @@ static void sas_ex_get_linkrate(struct domain_device *parent,
>  			sas_port_add_phy(port, phy->phy);
>  		}
>  	}
> -	child->linkrate = min(parent_phy->linkrate, child->max_linkrate);
> +	child->linkrate = min(parent_phy->linkrate, child->min_linkrate);

This patch doesn't look right.  It will clamp the phy to the minimum
possible link rate.  The child is supposed to support everywhere between
child->min_linkrate and child->max_linkrate.  The reason why we pick the
max is because we should use that if the parent supports it, and fall
back only if the parent isn't capable.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/