linux-kernel - Re: [PATCH] x86, efi: Do not reserve boot services regions within reserved areas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110614152101.GA17773@srcf.ucam.org>
Date:	Tue, 14 Jun 2011 16:21:02 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Maarten Lankhorst <m.b.lankhorst@...il.com>
Cc:	Yinghai Lu <yinghai@...nel.org>, Jim Bos <jim876@...all.nl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, efi: Do not reserve boot services regions within
 reserved areas

On Tue, Jun 14, 2011 at 05:03:14PM +0200, Maarten Lankhorst wrote:

> +		/* Could not reserve boot area */
> +		if (!size)
> +			continue;
> +
> +		printk(KERN_INFO PFX "Freeing boot area "
> +			"[0x%llx-0x%llx)\n", start, start+size);

Probably don't need the printk - we could be dumping a few hundred of 
those.

> -		  "Kernel-defined memdesc doesn't match the one from EFI!\n");
> +		  "Kernel-defined memdesc (%lu) "
> +			"doesn't match the one from EFI(%lu)!\n",
> +			sizeof(efi_memory_desc_t), memmap.desc_size);

And drop this hunk. It's entirely valid for an implementation to do 
this, we should just delete the message entirely.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/