linux-kernel - Re: [PATCH] power: opp: Fix rcu_dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2011 10:38:37 -0500
From:	"Menon, Nishanth" <nm@...com>
To:	Santosh Shilimkar <santosh.shilimkar@...com>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Kevin Hilman <khilman@...prootsystems.com>
Subject: Re: [PATCH] power: opp: Fix rcu_dereference_check() without protection!

On Tue, Jun 14, 2011 at 08:03, Santosh Shilimkar
<santosh.shilimkar@...com> wrote:
> With RCU debug options enabled, below warning is observed.
>
> ===================================================
> [ INFO: suspicious rcu_dereference_check() usage. ]
> ---------------------------------------------------
> drivers/base/power/opp.c:151 invoked rcu_dereference_check() without protection!
>
> other info that might help us debug this:
>
> rcu_scheduler_active = 1, debug_locks = 1
> no locks held by swapper/1.
> ...
>
> ---------------------------------------------------
>
> Fix the same by protecting it with rcu_read lock.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@...com>
> Cc: Rafael J. Wysocki <rjw@...k.pl>
> Cc: Nishanth Menon <nm@...com>
> Cc: Kevin Hilman <khilman@...prootsystems.com>
> ---
>  drivers/base/power/opp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> index 56a6899..cbed5e1 100644
> --- a/drivers/base/power/opp.c
> +++ b/drivers/base/power/opp.c
> @@ -148,7 +148,9 @@ unsigned long opp_get_voltage(struct opp *opp)
>        struct opp *tmp_opp;
>        unsigned long v = 0;
>
> +       rcu_read_lock();
>        tmp_opp = rcu_dereference(opp);
> +       rcu_read_unlock();
>        if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available)
>                pr_err("%s: Invalid parameters\n", __func__);
>        else
NAK. please read the Documentation/power/opp.txt
the usage is as follows:
rcu_read_lock();
opp = opp_find_freq_ceil();
voltage = opp_get_voltage(opp);
rcu_read_unlock();

the reason for this is that the opp pointer is not safe if we lock
just the dereferencing.

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/