linux-kernel - Re: [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110614164649.GB29015@tugrik.mns.mnsspb.ru>
Date:	Tue, 14 Jun 2011 20:46:49 +0400
From:	Kirill Smelkov <kirr@....spb.ru>
To:	Dan Carpenter <error27@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	Tomas Winkler <tomas.winkler@...el.com>,
	Mike Thomas <rmthomas@...olus.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] staging/easycap: Fix thinko in "bars" module
	option description

On Mon, Jun 13, 2011 at 03:27:17PM +0300, Dan Carpenter wrote:
> On Mon, Jun 13, 2011 at 04:18:29PM +0400, Kirill Smelkov wrote:
> > Both bars=0 and bars=1 were described as meaning to display bars on
> > signal lost. Actually bars=1 means "display bars", but bars=0 means
> > display raw source as is (usually black screen).
> 
> Your description up here is much better than the one in the README.
> Maybe just include yours and delete the original.

Thanks for head ups. Something like this:

---- 8< ----
From: Kirill Smelkov <kirr@....spb.ru>
Date: Mon, 13 Jun 2011 15:09:31 +0400
Subject: [PATCH v2] staging/easycap: Fix thinko in "bars" module option
 description

Both bars=0 and bars=1 were described as meaning to display bars on
signal lost. Actually bars=1 means "display bars", but bars=0 means
display raw source as is (usually black screen).

Instead of changing bars=0 to "_no_ testcard bars ..." as suggested by
Dan Carpenter reword the whole bars description for clarity.

Cc: Tomas Winkler <tomas.winkler@...el.com>
Cc: Mike Thomas <rmthomas@...olus.org>
Cc: Dan Carpenter <error27@...il.com>
Signed-off-by: Kirill Smelkov <kirr@....spb.ru>
---
 drivers/staging/easycap/README |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/easycap/README b/drivers/staging/easycap/README
index 16b8264..dadceb9 100644
--- a/drivers/staging/easycap/README
+++ b/drivers/staging/easycap/README
@@ -60,8 +60,8 @@ Three module parameters are defined:
 
 debug      the easycap module is configured at diagnostic level n (0 to 9)
 gain       audio gain level n (0 to 31, default is 16)
-bars       0 =>  testcard bars when incoming video signal is lost
-           1 =>  testcard bars when incoming video signal is lost (default)
+bars       whether to display testcard bars when incoming video signal is lost
+           0 => no, 1 => yes (default)
 
 
 SUPPORTED TV STANDARDS AND RESOLUTIONS
-- 
1.7.6.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/