linux-kernel - Re: [PATCH] FRV: Hook up gpiolib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5194.1308074912@redhat.com>
Date:	Tue, 14 Jun 2011 19:08:32 +0100
From:	David Howells <dhowells@...hat.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	grant@...retlab.ca
Subject: Re: [PATCH] FRV: Hook up gpiolib support

Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> Allow people to use gpiolib on FRV, mostly for build coverage as it
> seems more useful to standardise the API than handle making it optional.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Nack.

There's an ordering problem.  The #inclusion of asm-generic/gpio.h must come
both before *and* after the functions in asm/gpio.h.  Take gpio_get_value()
for instance, it requires __gpio_get_value() - which is defined by the generic
header - but is used by gpio_get_value_cansleep() in the generic header.

You must split asm-generic/gpio.h.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/