linux-kernel - Re: [PATCH] FRV: Hook up gpiolib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110615144823.GA2806@opensource.wolfsonmicro.com>
Date:	Wed, 15 Jun 2011 15:48:24 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-kernel@...r.kernel.org, grant@...retlab.ca
Subject: Re: [PATCH] FRV: Hook up gpiolib support

On Tue, Jun 14, 2011 at 07:08:32PM +0100, David Howells wrote:

> There's an ordering problem.  The #inclusion of asm-generic/gpio.h must come
> both before *and* after the functions in asm/gpio.h.  Take gpio_get_value()
> for instance, it requires __gpio_get_value() - which is defined by the generic
> header - but is used by gpio_get_value_cansleep() in the generic header.

Could you be more specific about the issue you see here?  The arch
header includes the generic header which appears to prototype all the
functions before it uses them.  I do also note that this is a verbatim
copy of the header that's been used on PowerPC for some considerable
time; is this some FRV specific limitation that wouldn't affect other
architectures?

> You must split asm-generic/gpio.h.

I must?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/