linux-kernel - Re: [Cocci] Re: [PATCH v2] coccinelle: if (ret) return ret; return ret; semantic patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110615160524.GA9986@farmergreg.com>
Date:	Wed, 15 Jun 2011 11:05:24 -0500
From:	Greg Dietsche <Gregory.Dietsche@....edu>
To:	Julia Lawall <julia@...u.dk>
Cc:	linux-kernel@...r.kernel.org, cocci@...u.dk, Gilles.Muller@...6.fr
Subject: Re: [Cocci] Re: [PATCH v2] coccinelle: if (ret) return ret; return
 ret; semantic patch

On Wed, Jun 15, 2011 at 05:35:47PM +0200, Julia Lawall wrote:
> > except that 4 of the 5 ORs are cases where we want to do the -return ret; +
> > return ret; So I suppose for performance, I should actually add the +/- to
> > each of the 4 cases that we want cocci to generate a patch for?
> 
> Actually, it's probably not that big a deal.  It's only rewriting the ones 
> where there is a return ret just before, not all the returns in the code, 
> like I was originally thinking.

Ok :) I'll update the patch one last time - hopefully we've got everything nailed
down now :)

thanks for being so incredibly helpful!

Greg

> 
> julia
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/