| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1308176709-14765-1-git-send-email-Gregory.Dietsche@cuw.edu> Date: Wed, 15 Jun 2011 17:25:09 -0500 From: Greg Dietsche <Gregory.Dietsche@....edu> To: gregkh@...e.de Cc: brudley@...adcom.com, henryp@...adcom.com, dowan@...adcom.com, rvossen@...adcom.com, arend@...adcom.com, linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Greg Dietsche <Gregory.Dietsche@....edu> Subject: [PATCH] staging: brcm80211: return false if not a broadcom board This code looks wrong to me. I think it meant to return false if the board's vendor id isn't Broadcom's. Compile tested only. Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu> --- drivers/staging/brcm80211/brcmsmac/wlc_bmac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c b/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c index 4534926..ee13238 100644 --- a/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c +++ b/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c @@ -1943,7 +1943,7 @@ static bool wlc_validboardtype(struct wlc_hw_info *wlc_hw) } if (wlc_hw->sih->boardvendor != PCI_VENDOR_ID_BROADCOM) - return goodboard; + goodboard = false; return goodboard; } -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists