linux-kernel - Re: 3.0-rc2: mei breaks suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinfNKKeyC9RB-uvFSVq5OeNXiw95Q@mail.gmail.com>
Date:	Thu, 16 Jun 2011 11:19:57 +0200
From:	Maarten Lankhorst <m.b.lankhorst@...il.com>
To:	Stefan Seyfried <stefan.seyfried@...glemail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: 3.0-rc2: mei breaks suspend

Hi Stefan,

2011/6/16 Stefan Seyfried <stefan.seyfried@...glemail.com>:
> Hi,
>
> having the "mei" driver loaded, which happened automatically on my
> ThinkPad X200s, successfully prevents any suspend efforts:
>
> [39736.728116] pci_pm_suspend(): mei_pci_suspend+0x0/0xc0 [mei] returns 9999
>
> The code has not changed since 3.0-rc2, so I did not try compiling latest
> git.
>
> Jiri Slaby hinted that this code in drivers/staging/mei/wd.c is to blame:
>
> 169         ret = wait_event_interruptible_timeout(dev->wait_stop_wd,
> 170                                         dev->wd_stopped, 10 * HZ);
>
> I am, however, not familiar enough with timers and stuff to immediately
> spot the problem.
>
> Removing the module before suspend is a workaround.
>
> This could be considered a regression, as suspend worked very well before
> this driver was introduced :-)
Does changing that to wait_event_timeout work? My guess is that is
what he meant.

~Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/