linux-kernel - Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to devio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1106161118270.2204-100000@iolanthe.rowland.org>
Date:	Thu, 16 Jun 2011 11:20:45 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Tatyana Brokhman <tlinder@...eaurora.org>
cc:	greg@...ah.com, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <balbi@...com>,
	<ablay@...eaurora.org>, Amit Blay <ablay@...lcomm.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to
 devio.c

On Thu, 16 Jun 2011, Tatyana Brokhman wrote:

> Allow user space applications such as LIBUSB, to request
> streams alloc/dealloc from HCD that implements XHCI.
> 
> Signed-off-by: Amit Blay <ablay@...lcomm.com>
> Signed-off-by: Tatyana Brokhman <tlinder@...eaurora.org>

...

> diff --git a/include/linux/usbdevice_fs.h b/include/linux/usbdevice_fs.h
> index 15591d2..133c216 100644
> --- a/include/linux/usbdevice_fs.h
> +++ b/include/linux/usbdevice_fs.h
> @@ -108,6 +108,7 @@ struct usbdevfs_urb {
>  				  or 0 if none should be sent. */
>  	void __user *usercontext;
>  	struct usbdevfs_iso_packet_desc iso_frame_desc[0];
> +	unsigned int stream_id;
>  };
>  
>  /* ioctls for talking directly to drivers */
> @@ -165,6 +166,7 @@ struct usbdevfs_urb32 {
>  	compat_uint_t signr;
>  	compat_caddr_t usercontext; /* unused */
>  	struct usbdevfs_iso_packet_desc iso_frame_desc[0];
> +	compat_uint_t stream_id;
>  };

It would be nice if we could do this, but we can't.  We are not allowed 
to change an established ABI.  Every copy of libusb would have to be 
rebuilt.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/