linux-kernel - Re: [PATCH/RFC 2/5] usb:dummy_hcd: connect/disconnect test support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2011 19:16:28 +0300
From:	Felipe Balbi <balbi@...com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Tatyana Brokhman <tlinder@...eaurora.org>, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	balbi@...com, ablay@...eaurora.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RFC 2/5] usb:dummy_hcd: connect/disconnect test support

Hi,

On Thu, Jun 16, 2011 at 11:06:47AM -0400, Alan Stern wrote:
> On Thu, 16 Jun 2011, Tatyana Brokhman wrote:
> 
> > This implementation adds a new proprietary device control requests (to be
> > handled by the dummy_hcd) that initiates a connect/disconnect sequence.
> > The bRequest value of the new control request is 0x52.
> > It is used by the user-space Unit testing application.
> 
> This is not a bad idea.  On the other hand, it is slightly peculiar -- 
> it you're testing with real UDC hardware, you would do the 
> disconnect/reconnect sequence by hand (unplug and replug the USB 
> cable), not in software.

actually, this is quite useful. Specially for the controllers which
_can_ do soft-connect by toggling data pullups. I would rather have
these sort of thing maybe in composite.c, so that we can build tests
with all gadget drivers/controllers, not only dummy_hcd.

That said, I think now it's not the time to fiddle too much with these
details right now. So best to keep this in dummy_hcd until we know the
test tools are actually good.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)