linux-kernel - Re: [PATCH v4 02/12] omap_hsmmc: use original sg_len for dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikb=gXBpxSvgdg4Ni1sXj99m7zj2g@mail.gmail.com>
Date:	Fri, 17 Jun 2011 12:58:20 +0200
From:	Per Forlin <per.forlin@...aro.org>
To:	"S, Venkatraman" <svenkatr@...com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linaro-dev <linaro-dev@...ts.linaro.org>,
	David Vrabel <david.vrabel@....com>
Subject: Re: [PATCH v4 02/12] omap_hsmmc: use original sg_len for dma_unmap_sg

On 16 June 2011 15:16, S, Venkatraman <svenkatr@...com> wrote:
> On Thu, May 26, 2011 at 3:27 AM, Per Forlin <per.forlin@...aro.org> wrote:
>> Don't use the returned sg_len from dma_map_sg() as inparameter
>> to dma_unmap_sg(). Use the original sg_len for both dma_map_sg
>> and dma_unmap_sg.
>>
>> Signed-off-by: Per Forlin <per.forlin@...aro.org>
>> ---
>>  drivers/mmc/host/omap_hsmmc.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 259ece0..ad3731a 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -959,7 +959,8 @@ static void omap_hsmmc_dma_cleanup(struct omap_hsmmc_host *host, int errno)
>>        spin_unlock(&host->irq_lock);
>>
>>        if (host->use_dma && dma_ch != -1) {
>> -               dma_unmap_sg(mmc_dev(host->mmc), host->data->sg, host->dma_len,
>> +               dma_unmap_sg(mmc_dev(host->mmc), host->data->sg,
>> +                       host->data->sg_len,
>>                        omap_hsmmc_get_dma_dir(host, host->data));
>>                omap_free_dma(dma_ch);
>>        }
>> @@ -1343,7 +1344,7 @@ static void omap_hsmmc_dma_cb(int lch, u16 ch_status, void *cb_data)
>>                return;
>>        }
>>
>> -       dma_unmap_sg(mmc_dev(host->mmc), data->sg, host->dma_len,
>> +       dma_unmap_sg(mmc_dev(host->mmc), data->sg, data->sg_len,
>>                omap_hsmmc_get_dma_dir(host, data));
>>
>>        req_in_progress = host->req_in_progress;
>> --
>> 1.7.4.1
>>
>
> Reviewed-by: Venkatraman S <svenkatr@...com>
>
> Perhaps this doesn't belong to $FEATURE and can be posted as a separate patch ?
Yes, I will resend it as a separate patch.

Thanks,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/