linux-kernel - Re: reorganized struct inode results in unaligned accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110619.160150.1199476848151993579.davem@davemloft.net>
Date:	Sun, 19 Jun 2011 16:01:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	torvalds@...ux-foundation.org, mroos@...ux.ee,
	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org
Subject: Re: reorganized struct inode results in unaligned accesses

From: Andi Kleen <andi@...stfloor.org>
Date: Sun, 19 Jun 2011 15:35:30 -0700

> Linus Torvalds <torvalds@...ux-foundation.org> writes:
>>
>> Dang. I guess it needs to be made "unsigned long" again. Which is a
>> shame, because we only use a couple of bits from there, and "struct
>> inode" really is much too big already.
> 
> In the past it was usually enough to just align it to alignof(unsigned
> long), not actually make it long. struct page went through this
> a long time ago.

Hmmm, can this scheme actually work out properly on both big and
little endian?  Because endianness determines whether the bits start
in the "lower addressed" 32-bit word or the "higher addressed" 32-bit
word.

If this trick is being attempted elsewhere, I think it could perhaps
account for some strange bugs :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/