linux-kernel - Re: reorganized struct inode results in unaligned accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110619231402.GK16236@one.firstfloor.org>
Date:	Mon, 20 Jun 2011 01:14:02 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	David Miller <davem@...emloft.net>
Cc:	andi@...stfloor.org, torvalds@...ux-foundation.org, mroos@...ux.ee,
	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org
Subject: Re: reorganized struct inode results in unaligned accesses

> Hmmm, can this scheme actually work out properly on both big and
> little endian?  Because endianness determines whether the bits start
> in the "lower addressed" 32-bit word or the "higher addressed" 32-bit
> word.

True, it needs an ifdef, with the other order in BE. struct page has that iirc.

> 
> If this trick is being attempted elsewhere, I think it could perhaps
> account for some strange bugs :-)

Well if you want to be sure better try to get rid of the void *

(I tried early on in x86-64, it caused a lot of warnings all over)

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/