linux-kernel - Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m239j3tb3w.fsf@bob.laptop.org>
Date:	Tue, 21 Jun 2011 12:14:59 -0400
From:	Chris Ball <cjb@...top.org>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	James Hogan <james@...anarts.com>, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS

Hi,

On Tue, Jun 21 2011, Michał Mirosław wrote:
> On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
>> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
>> the CONFIG_ before it when used by the preprocessor.
>> 
>> Signed-off-by: James Hogan <james@...anarts.com>
>> ---
>>  drivers/misc/cb710/sgbuf2.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
>> index d019746..2a40d0e 100644
>> --- a/drivers/misc/cb710/sgbuf2.c
>> +++ b/drivers/misc/cb710/sgbuf2.c
>> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
>> sg_mapping_iter *miter)
>> 
>>  static inline bool needs_unaligned_copy(const void *ptr)
>>  {
>> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>>  	return false;
>>  #else
>>  	return ((ptr - NULL) & 3) != 0;
>
> Acked-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

Thanks, pushed to mmc-next for 3.0.

(James, your patch was corrupt due to a hard line break on the @@
line -- please fix that next time around.)

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/