| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110621.160334.1438754754048406782.davem@davemloft.net> Date: Tue, 21 Jun 2011 16:03:34 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jj@...osbits.net Cc: netdev@...r.kernel.org, coreteam@...filter.org, netfilter@...r.kernel.org, netfilter-devel@...r.kernel.org, linux-kernel@...r.kernel.org, xeb@...l.ru Subject: Re: [PATCH] Remove redundant linux/version.h includes from net/ From: Jesper Juhl <jj@...osbits.net> Date: Tue, 21 Jun 2011 00:13:10 +0200 (CEST) > It was suggested by "make versioncheck" that the follwing includes of > linux/version.h are redundant: > > /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed. > /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed. > /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed. > /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed. > /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed. > > and it seems that it is right. > > Beyond manually inspecting the source files I also did a few build > tests with various configs to confirm that including the header in > those files is indeed not needed. > > Here's a patch to remove the pointless includes. > > Signed-off-by: Jesper Juhl <jj@...osbits.net> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists