linux-kernel - Re: [PATCH 2/8] kill tracehook_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110623122253.GM30101@htj.dyndns.org>
Date:	Thu, 23 Jun 2011 14:22:53 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	hch@...radead.org
Subject: Re: [PATCH 2/8] kill tracehook_notify_death()

Hello, Oleg.

On Wed, Jun 22, 2011 at 11:08:34PM +0200, Oleg Nesterov wrote:
> Kill tracehook_notify_death(), reimplement the logic in its caller,
> exit_notify().
> 
> This also fixes a minor bug, if the exiting task is the group_leader
> and it is traced by its real_parent, tracehook_notify_death() returns
> task->exit_signal or SIGCHLD depending on thread_group_empty(), this
> looks strange.

Maybe we should do the above in a separate patch?

> -	if (tsk->exit_signal != SIGCHLD && !task_detached(tsk) &&
> +	if (thread_group_leader(tsk) && tsk->exit_signal != SIGCHLD &&

Hmmm... it probably depends on POV but wouldn't (exit_signal != -1 &&
exit_signal != SIGCHLD) be easier?  The logic here is about demoting
specials sigs to SIGCHLD under certain circumstances and the check is
there to prevent promoting -1 to SIGCHLD.  I agree the detached() is
more distracting than helping but thread_group_leader() seems
unnecessarily indirect.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/