linux-kernel - [PATCH 06/11] spi-dw: Force error on out of range chip select.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2011 19:00:08 -0700
From:	dirk.brandewie@...il.com
To:	linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net
Cc:	Dirk Brandewie <dirk.brandewie@...il.com>
Subject: [PATCH 06/11] spi-dw: Force error on out of range chip select.

From: Dirk Brandewie <dirk.brandewie@...il.com>

BUG_ON() if the selected chip select is out of range.

Signed-off-by: Dirk Brandewie <dirk.brandewie@...il.com>
---
 drivers/spi/spi-dw.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
index 860bc34..3fa4c13 100644
--- a/drivers/spi/spi-dw.h
+++ b/drivers/spi/spi-dw.h
@@ -178,8 +178,7 @@ static inline void spi_dw_set_clk(struct spi_dw *dws, u16 div)
 
 static inline void spi_dw_chip_sel(struct spi_dw *dws, u16 cs)
 {
-	if (cs > dws->num_cs)
-		return;
+	BUG_ON(cs >= dws->master->num_chipselect);
 
 	if (dws->cs_control)
 		dws->cs_control(SPI_DW_ASSERT);
-- 
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/