lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 23 Jun 2011 11:26:34 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	rusty@...tcorp.com.au, virtualization@...ts.linux-foundation.org,
	horms@...ge.net.au, mst@...hat.com, iws@...o.caltech.edu
Subject: Re: [PATCH 02/02] virtio: Add virtio platform driver

Hi Mike,

On Wed, Jun 22, 2011 at 3:27 AM, Mike Frysinger <vapier@...too.org> wrote:
> On Tue, Jun 21, 2011 at 06:26, Magnus Damm wrote:
>> +config VIRTIO_PLATFORM
>> +       tristate "Platform driver for virtio devices (EXPERIMENTAL)"
>> +       select VIRTIO
>> +       select VIRTIO_RING
>> +       select VIRTIO_LGUEST
>> +       ---help---
>> +        This drivers provides support for virtio based paravirtual device
>> +        drivers over a platform bus.
>> +
>> +        If unsure, say N.
>
> be nice to add a note as to the name of the module if the user selects "M"

Yes, good idea!

>> --- /dev/null
>> +++ work/drivers/virtio/virtio_platform.c       2011-03-03 16:07:31.000000000 +0900
>> --- /dev/null
>> +++ work/include/linux/virtio_platform.h        2011-03-03 15:56:54.000000000 +0900
>
> both files lack a comment block at the top
> /*
>  * one line desc of file
>  *
>  * copyright
>  *
>  * license blurb
>  */

Sure! I will include these changes in the next version!

Thank you!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ