linux-kernel - Re: [34-longterm 228/247] arch/x86/oprofile/op_model_amd.c: Perform initialisation on a single CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110624092302.GI20052@erda.amd.com>
Date:	Fri, 24 Jun 2011 11:23:02 +0200
From:	Robert Richter <robert.richter@....com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	"stable@...nel.org" <stable@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable-review@...nel.org" <stable-review@...nel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [34-longterm 228/247] arch/x86/oprofile/op_model_amd.c: Perform
 initialisation on a single CPU

On 23.06.11 13:34:56, Paul Gortmaker wrote:
> From: Robert Richter <robert.richter@....com>
> 
>                    -------------------
>     This is a commit scheduled for the next v2.6.34 longterm release.
>     If you see a problem with using this for longterm, please comment.
>                    -------------------
> 
> commit c7c25802b39c443b3745cfa973dc49a97a3491f8 upstream.
> 
> Disable preemption in init_ibs(). The function only checks the
> ibs capabilities and sets up pci devices (if necessary). It runs
> only on one cpu but operates with the local APIC and some MSRs,
> thus it is better to disable preemption.
> 
> [    7.034377] BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/483
> [    7.034385] caller is setup_APIC_eilvt+0x155/0x180
> [    7.034389] Pid: 483, comm: modprobe Not tainted 2.6.37-rc1-20101110+ #1
> [    7.034392] Call Trace:
> [    7.034400]  [<ffffffff812a2b72>] debug_smp_processor_id+0xd2/0xf0
> [    7.034404]  [<ffffffff8101e985>] setup_APIC_eilvt+0x155/0x180
> [ ... ]
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=22812
> 
> Reported-by: <atswartz@...il.com>
> Signed-off-by: Robert Richter <robert.richter@....com>
> Cc: oprofile-list@...ts.sourceforge.net <oprofile-list@...ts.sourceforge.net>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Rafael J. Wysocki <rjw@...k.pl>
> Cc: Dan Carpenter <error27@...il.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> LKML-Reference: <20110103111514.GM4739@...a.amd.com>
> [ small cleanups ]
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  arch/x86/oprofile/op_model_amd.c |   24 ++++++++++++++++--------
>  1 files changed, 16 insertions(+), 8 deletions(-)

This patch introduces a sleeping-while-atomic bug. There is another
upstream fix on top, see:

commit 3d2606f42984613d324ad3047cf503bcddc3880a
Author: Robert Richter <robert.richter@....com>
Date:   Fri May 20 09:46:54 2011 +0200

    oprofile, x86: Enable preemption during pci device setup in IBS init

This fix should be applied too (or instead).

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/