linux-kernel - Re: [PATCH] regulator: twl: Add 'fixed' set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110624111929.GC9483@opensource.wolfsonmicro.com>
Date:	Fri, 24 Jun 2011 12:19:29 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jassi Brar <jassisinghbrar@...il.com>
Cc:	linux-kernel@...r.kernel.org, ti@...ts.linaro.org,
	linux-omap@...r.kernel.org, lrg@...com, sameo@...ux.intel.com,
	Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH] regulator: twl: Add 'fixed' set_voltage callback

On Fri, Jun 24, 2011 at 02:16:54AM +0530, Jassi Brar wrote:
> Define dummy set_voltage callback for fixed lines,
> without which voltage constraints fail to apply.
> 
> Signed-off-by: Jassi Brar <jaswinder.singh@...aro.org>

No, this isn't sensible - fixed voltage regulators aren't an unusual
property of this device, they've very common.  The core should handle
this gracefully.  Probably whatever consumer is doing the setting also
ought to be updated to check that the voltages it wants to set are
supported at startup since otherwise it can end up repeatedly trying to
set something that'll never work.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/