linux-kernel - Re: [PATCH 0/3 v3] rcu: Detect rcu uses under extended quiescent state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110624112045.GF8058@somewhere.redhat.com>
Date:	Fri, 24 Jun 2011 13:20:49 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 0/3 v3] rcu: Detect rcu uses under extended quiescent
 state

On Thu, Jun 23, 2011 at 08:53:11PM -0700, Paul E. McKenney wrote:
> On Fri, Jun 24, 2011 at 01:12:37AM +0200, Frederic Weisbecker wrote:
> > This time I have no current practical cases to fix. Those I fixed
> > in previous versions were actually using rcu_dereference_raw(), which
> > is legal in extended qs.
> > 
> > Frederic Weisbecker (3):
> >   rcu: Detect illegal rcu dereference in extended quiescent state
> >   rcu: Inform the user about dynticks idle mode on PROVE_RCU warning
> >   rcu: Warn when rcu_read_lock() is used in extended quiescent state
> > 
> >  include/linux/rcupdate.h |   68 +++++++++++++++++++++++++++++++++++++++-------
> >  kernel/lockdep.c         |    4 +++
> >  kernel/rcupdate.c        |    4 +++
> >  kernel/rcutiny.c         |   13 +++++++++
> >  kernel/rcutree.c         |   14 +++++++++
> >  5 files changed, 93 insertions(+), 10 deletions(-)
> 
> Queued, thank you, Frederic!
> 
> I have also applied your approach to SRCU, and I applied the following
> to simplify the code a bit -- please let me know if there are any
> problems with this approach.
> 
> 							Thanx, Paul
> 
> ------------------------------------------------------------------------
> 
> rcu: Remove one layer of abstraction from PROVE_RCU checking
> 
> Simplify things a bit by substituting the definitions of the single-line
> rcu_read_acquire(), rcu_read_release(), rcu_read_acquire_bh(),
> rcu_read_release_bh(), rcu_read_acquire_sched(), and
> rcu_read_release_sched() functions at their call points.
> 
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

Yeah looks good. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/