linux-kernel - Re: [PATCH] mfd: omap: Restore TLL initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikODvHRWa6HHaWZr2Gy0SjBbn2J-w@mail.gmail.com>
Date:	Fri, 24 Jun 2011 12:33:09 +0530
From:	Jaswinder Singh <jaswinder.singh@...aro.org>
To:	"Munegowda, Keshava" <keshava_mgowda@...com>
Cc:	Jassi Brar <jassisinghbrar@...il.com>,
	linux-kernel@...r.kernel.org, ti@...ts.linaro.org,
	parthab@...ia.ti.com, sameo@...ux.intel.com, gadiyar@...com,
	balbi@...com, linux-omap@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] mfd: omap: Restore TLL initialization

On 24 June 2011 11:52, Munegowda, Keshava <keshava_mgowda@...com> wrote:
> On Fri, Jun 24, 2011 at 2:31 AM, Jassi Brar <jassisinghbrar@...il.com> wrote:
>> The commit
>>  7e6502d577106fb5b202bbaac64c5f1b065 'mfd: Add omap-usbhs runtime PM support'
>> besides moving to RPM, removes necessary TLL initialization as well.
>>
>> Restore the TLL initialization, without which device detection fails.
>>
>> Signed-off-by: Jassi Brar <jaswinder.singh@...aro.org>
>
> if you move to RPM, you should'tn access these configuration/reset
> registers in your driver.
Sorry I don't get it.  Obviously the RPM backend here doesn't initialize
the TLL and if it only manages the clocks, can't we safely assume that
the pm_runtime_get_sync will get clocks to speed and the driver does
the TLL init ?

> moreover, the patch 'mfd: Add omap-usbhs runtime PM support' is
> already reverted.
Ok, though if the ultimate goal is to move on to RPM, this would be a
step back.
Btw, which tree could I find the revert in ?

Thanks,
Jassi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/