linux-kernel - Re: [PATCH] mfd: omap: Restore TLL initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ei2f9bja.fsf@ti.com>
Date:	Mon, 27 Jun 2011 15:04:09 -0700
From:	Kevin Hilman <khilman@...com>
To:	"Munegowda\, Keshava" <keshava_mgowda@...com>
Cc:	Jassi Brar <jassisinghbrar@...il.com>,
	linux-kernel@...r.kernel.org, ti@...ts.linaro.org,
	parthab@...ia.ti.com, sameo@...ux.intel.com, gadiyar@...com,
	balbi@...com, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org, Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH] mfd: omap: Restore TLL initialization

"Munegowda, Keshava" <keshava_mgowda@...com> writes:

> On Fri, Jun 24, 2011 at 2:31 AM, Jassi Brar <jassisinghbrar@...il.com> wrote:
>> The commit
>>  7e6502d577106fb5b202bbaac64c5f1b065 'mfd: Add omap-usbhs runtime PM support'
>> besides moving to RPM, removes necessary TLL initialization as well.
>>
>> Restore the TLL initialization, without which device detection fails.
>>
>> Signed-off-by: Jassi Brar <jaswinder.singh@...aro.org>

[...]

> if you move to RPM, you should'tn access these configuration/reset
> registers in your driver.

Yes, but Jaswinder's changelog clearly shows that the runtime PM (and
thus hwmod) init is not doing the equivalent of what was removed from
the driver.

A hunch after a quick glance is that the driver changes are only doing
runtime PM calls on the UHH device and not the TTL device.  In fact,
the patch that builds the USB host omap_device[1] doesn't even build one.

> moreover, the patch 'mfd: Add omap-usbhs runtime PM support' is
> already reverted.

It is reverted for this merge window, but will be added back for the
next window, so Jaswinder's problem still needs to be fixed the right way.

Please rework the USB host runtime PM conversion so that *all* the IP
blocks are managed by runtime PM and the driver is doing runtime PM
calls for all the devices used.

Kevin

[1] http://marc.info/?l=linux-omap&m=130693494126396&w=2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/